romainfrancois commented on a change in pull request #11225:
URL: https://github.com/apache/arrow/pull/11225#discussion_r718416073
##########
File path: r/src/altrep.cpp
##########
@@ -496,24 +611,76 @@ void InitAltIntegerClass(DllInfo* dll, const char* name) {
InitAltIntegerMethods<AltrepClass>(AltrepClass::class_t, dll);
}
+template <typename AltrepClass>
+void InitAltStringClass(DllInfo* dll, const char* name) {
+ AltrepClass::class_t = R_make_altstring_class(name, "arrow", dll);
+ R_set_altrep_Length_method(AltrepClass::class_t, AltrepClass::Length);
+ R_set_altrep_Inspect_method(AltrepClass::class_t, AltrepClass::Inspect);
+ R_set_altrep_Duplicate_method(AltrepClass::class_t, AltrepClass::Duplicate);
+ R_set_altrep_Serialized_state_method(AltrepClass::class_t,
+ AltrepClass::Serialized_state);
+ R_set_altrep_Unserialize_method(AltrepClass::class_t,
AltrepClass::Unserialize);
+ R_set_altrep_Coerce_method(AltrepClass::class_t, AltrepClass::Coerce);
+
+ R_set_altvec_Dataptr_method(AltrepClass::class_t, AltrepClass::Dataptr);
+ R_set_altvec_Dataptr_or_null_method(AltrepClass::class_t,
AltrepClass::Dataptr_or_null);
+
+ R_set_altstring_Elt_method(AltrepClass::class_t, AltrepClass::Elt);
+ R_set_altstring_Set_elt_method(AltrepClass::class_t, AltrepClass::Set_elt);
+ R_set_altstring_No_NA_method(AltrepClass::class_t, AltrepClass::No_NA);
+ R_set_altstring_Is_sorted_method(AltrepClass::class_t,
AltrepClass::Is_sorted);
+}
+
// initialize the altrep classes
void Init_Altrep_classes(DllInfo* dll) {
- InitAltRealClass<AltrepArrayPrimitive<REALSXP>>(dll, "array_dbl_vector");
- InitAltIntegerClass<AltrepArrayPrimitive<INTSXP>>(dll, "array_int_vector");
+ InitAltRealClass<AltrepVectorPrimitive<REALSXP>>(dll,
"arrow::array_dbl_vector");
+ InitAltIntegerClass<AltrepVectorPrimitive<INTSXP>>(dll,
"arrow::array_int_vector");
+
+ InitAltStringClass<AltrepVectorString<StringType>>(dll,
"arrow::array_string_vector");
+ InitAltStringClass<AltrepVectorString<LargeStringType>>(
+ dll, "arrow::array_large_string_vector");
}
+} // namespace altrep
+} // namespace r
+} // namespace arrow
+
+#endif // HAS_ALTREP
Review comment:
on R < 3.5 and we currently support >= 3.3.
```
Depends: R (>= 3.3)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
