emkornfield commented on a change in pull request #11302:
URL: https://github.com/apache/arrow/pull/11302#discussion_r723836536
##########
File path: cpp/src/arrow/python/datetime.cc
##########
@@ -71,6 +74,26 @@ bool MatchFixedOffset(const std::string& tz,
util::string_view* sign,
return iter == (tz.data() + tz.size());
}
+static PyTypeObject MonthDayNanoTupleType = {};
+
+constexpr char* NonConst(const char* st) {
+ // Hack for python versions < 3.7 where members of PyStruct members
+ // where non-const (C++ doesn't like assigning string literals to these
types)
+ return const_cast<char*>(st);
Review comment:
we do, I asked that we ddidn't drop it last release. I would also ask
that we don't drop it this release (i.e. keep it through its full python
support cycle. There are a number of consumers of pyarrow that try to keep
support for python versions until they dropped it which is end of this year).
This was caught because we run it in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
