emkornfield commented on a change in pull request #11310:
URL: https://github.com/apache/arrow/pull/11310#discussion_r724669537
##########
File path: go/arrow/internal/arrjson/arrjson_test.go
##########
@@ -2786,6 +2833,44 @@ func makeIntervalsWantJSONs() string {
"milliseconds": 15
}
]
+ },
+ {
+ "name": "nanos",
+ "count": 5,
+ "VALIDITY": [
+ 1,
+ 0,
+ 0,
+ 1,
+ 1
+ ],
+ "DATA": [
+ {
+ "months": 11,
+ "days": 11,
+ "nanoseconds": 11000
+ },
+ {
+ "months": 12,
+ "days": 12,
+ "nanoseconds": 12000
+ },
+ {
+ "months": 13,
+ "days": 13,
+ "nanoseconds": 13000
+ },
+ {
+ "months": 14,
+ "days": 14,
+ "nanoseconds": 14000
+ },
+ {
+ "months": 15,
+ "days": 15,
+ "nanoseconds": 15000
Review comment:
same comments, some negative values would be nice.
##########
File path: go/arrow/internal/arrjson/arrjson_test.go
##########
@@ -2786,6 +2833,44 @@ func makeIntervalsWantJSONs() string {
"milliseconds": 15
}
]
+ },
+ {
+ "name": "nanos",
+ "count": 5,
+ "VALIDITY": [
+ 1,
+ 0,
+ 0,
+ 1,
+ 1
+ ],
+ "DATA": [
+ {
+ "months": 11,
+ "days": 11,
+ "nanoseconds": 11000
+ },
+ {
+ "months": 12,
+ "days": 12,
+ "nanoseconds": 12000
+ },
+ {
+ "months": 13,
+ "days": 13,
+ "nanoseconds": 13000
+ },
+ {
+ "months": 14,
+ "days": 14,
+ "nanoseconds": 14000
+ },
+ {
+ "months": 15,
+ "days": 15,
+ "nanoseconds": 15000
Review comment:
and maybe 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
