zeroshade commented on a change in pull request #11310:
URL: https://github.com/apache/arrow/pull/11310#discussion_r725153947
##########
File path: go/arrow/datatype.go
##########
@@ -95,21 +95,30 @@ const (
// nanoseconds since midnight
TIME64
- // INTERVAL is YEAR_MONTH or DAY_TIME interval in SQL style
- INTERVAL
+ // INTERVAL_MONTHS is YEAR_MONTH in SQL style
+ INTERVAL_MONTHS
- // DECIMAL is a precision- and scale-based decimal type. Storage type
depends on the
+ // INTERVAL_DAY_TIME is DAY_TIME in SQL style
+ INTERVAL_DAY_TIME
+
+ // DECIMAL128 is a precision- and scale-based decimal type. Storage
type depends on the
// parameters.
- DECIMAL
Review comment:
added, also after the next release this will be versioned properly so
that consumers who upgrade would have to explicitly say to upgrade to the new
major version which is nice.
##########
File path: go/arrow/array/interval_test.go
##########
@@ -274,3 +274,128 @@ func TestDayTimeIntervalBuilder_Empty(t *testing.T) {
assert.Equal(t, want, dtValues(arr))
arr.Release()
}
+
+func TestMonthDayNanoArray(t *testing.T) {
+ mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
+ defer mem.AssertSize(t, 0)
+
+ var (
+ want = []arrow.MonthDayNanoInterval{{1, 1, 1000}, {2, 2,
2000}, {3, 3, 3000}, {4, 4, 4000}}
Review comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
