zeroshade edited a comment on pull request #11310: URL: https://github.com/apache/arrow/pull/11310#issuecomment-938757883
@emkornfield So the formatting changes happened due to the length of the name `MonthDayNanoInterval` since I auto run `go fmt` on the files which will line things up. Since the name is so long, it ends up changing the formatting a bit in order to maintain the alignment of the code, that's all. If you think that doing the flatbuf update separately from the actual new logic would be beneficial I can do that, mostly I didn't think anyone would be directly reviewing the generated flatbuf code so didn't consider it necessary to break it out as a separate change. That said, the changes to the enum values to line up with the C++ type ids could be broken out as a separate change to be done first, before the flatbuf and `MonthDayNanoInterval` logic, which I can do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
