dragosmg commented on a change in pull request #11355:
URL: https://github.com/apache/arrow/pull/11355#discussion_r726966183
##########
File path: r/R/expression.R
##########
@@ -215,7 +215,7 @@ build_expr <- function(FUN,
} else if (FUN == "%/%") {
# In R, integer division works like floor(float division)
out <- build_expr("/", args = args)
- return(out$cast(int32(), allow_float_truncate = TRUE))
+ return(nse_funcs$floor(out))
Review comment:
Now I'm not sure if any change is needed to arrow-datum. I don't think
we can use `"floor"` here since it outputs a `float` which we would need to
cast as `int`. Maybe a removal of `allow_float_truncate = TRUE`?
https://github.com/apache/arrow/blob/157d48ccd47a488d419cc50d440a04c2796f1462/r/R/arrow-datum.R#L106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
