nealrichardson commented on a change in pull request #11355:
URL: https://github.com/apache/arrow/pull/11355#discussion_r727107884
##########
File path: r/R/expression.R
##########
@@ -215,7 +215,7 @@ build_expr <- function(FUN,
} else if (FUN == "%/%") {
# In R, integer division works like floor(float division)
out <- build_expr("/", args = args)
- return(out$cast(int32(), allow_float_truncate = TRUE))
+ return(nse_funcs$floor(out))
Review comment:
If calling floor doesn't work there, then it won't work correctly in
expression.R. You could either add a test to test-dplyr-funcs-math.R to confirm
(since that's where the expression code is exercised), or revert the change
since it doesn't seem strictly necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
