nealrichardson commented on a change in pull request #11355:
URL: https://github.com/apache/arrow/pull/11355#discussion_r727166506



##########
File path: r/R/expression.R
##########
@@ -215,7 +215,7 @@ build_expr <- function(FUN,
     } else if (FUN == "%/%") {
       # In R, integer division works like floor(float division)
       out <- build_expr("/", args = args)
-      return(out$cast(int32(), allow_float_truncate = TRUE))
+      return(Expression$create("floor", out))

Review comment:
       Seems like we need to add a division test to the dplyr/expression path
   
   ```suggestion
         return(Expression$create("floor", out)$cast(int32()))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to