9prady9 commented on a change in pull request #11674:
URL: https://github.com/apache/arrow/pull/11674#discussion_r748736842
##########
File path: cpp/src/arrow/array/array_nested.cc
##########
@@ -680,7 +680,7 @@ Result<std::shared_ptr<Array>>
SparseUnionArray::GetFlattenedField(
if (child_null_bitmap) {
BitmapAnd(flattened_null_bitmap->data(), child_offset,
child_null_bitmap->data(),
child_offset, child_data->length, child_offset,
- flattened_null_bitmap->mutable_data());
+ flattened_null_bitmap->mutable_data(), /*out pop count*/
nullptr);
Review comment:
I did think about that, but wasn't sure if default arguments are used in
exported functions, especially in the functions that had pointers and basic
types compared to bitmap functions that returned class objects.
Is there any C API in arrow where this would apply ? such as API's that are
wrapped around from other languages like Rust ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
