9prady9 commented on a change in pull request #11674:
URL: https://github.com/apache/arrow/pull/11674#discussion_r748737695
##########
File path: cpp/src/arrow/util/bitmap_ops.cc
##########
@@ -311,39 +345,49 @@ Result<std::shared_ptr<Buffer>> BitmapAnd(MemoryPool*
pool, const uint8_t* left,
int64_t left_offset, const uint8_t*
right,
int64_t right_offset, int64_t length,
int64_t out_offset) {
+ // TODO(pradeep) Figure out the return type for this version of BitmapOps
+ int64_t out_pop_count = 0;
return BitmapOp<std::bit_and>(pool, left, left_offset, right, right_offset,
length,
- out_offset);
+ out_offset, &out_pop_count);
Review comment:
Wanted to ask the arrow devs if the functions returning class objects
also need to be modified to return pop count. It is an incomplete change ( I
though I left this PR in draft mode, hm). Please share your thoughts - if you
don't want to change these versions of bitmap API calls or otherwise. Hence
left the TODO line above this function call
https://github.com/apache/arrow/pull/11674/files#diff-1162624f731f4758d9b900e493a4551a266ea06d081f7ade43a21e333a63d8c0R348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
