cyb70289 commented on a change in pull request #11674:
URL: https://github.com/apache/arrow/pull/11674#discussion_r748959066
##########
File path: cpp/src/arrow/util/bitmap_ops.h
##########
@@ -124,7 +124,8 @@ Result<std::shared_ptr<Buffer>> BitmapAnd(MemoryPool* pool,
const uint8_t* left,
/// the results in out starting at the given bit-offset.
ARROW_EXPORT
void BitmapAnd(const uint8_t* left, int64_t left_offset, const uint8_t* right,
- int64_t right_offset, int64_t length, int64_t out_offset,
uint8_t* out);
+ int64_t right_offset, int64_t length, int64_t out_offset,
uint8_t* out,
+ int64_t* const out_pop_count);
Review comment:
`const` parameter may be useful in definition, but putting it in
declaration is a bit weird IMO.
Another reason is just to be consistent with existing parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
