viirya commented on a change in pull request #1319:
URL: https://github.com/apache/arrow-datafusion/pull/1319#discussion_r752665715
##########
File path: datafusion/src/optimizer/constant_folding.rs
##########
@@ -101,7 +105,30 @@ impl OptimizerRule for ConstantFolding {
// fold constants and then simplify
.rewrite(&mut const_evaluator)?
.rewrite(&mut simplifier)?;
- Ok(new_e)
+
+ let new_name = &new_e.name(plan.schema());
+
+ // Some plans will be candidates in projection
pushdown rule to
+ // trim expressions based on expression names. We need
to keep
+ // expression name for them.
+ let is_plan_for_projection_pushdown = matches!(
+ plan,
+ LogicalPlan::Window { .. }
Review comment:
> Basically I think the code needs to do something like walk over the
field names in the output schema and if they names of the rewritten exprs
weren't the same add an alias;
This sounds promising. No, I've not tried `columnize_expr`. Let me revise
this and see if it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
