viirya commented on pull request #1319:
URL: https://github.com/apache/arrow-datafusion/pull/1319#issuecomment-974508956
For the approach of looking field name, it is similar. Some tests are needed
to update, e.g.
1.
optimizer::constant_folding::tests::optimize_plan_support_projectionorg_expr
```
left: `"Projection: #test.a, #test.d, NOT #test.b AS test.b =
Boolean(false)\n TableScan: test projection=None"`,
right: `"Projection: #test.a, #test.d, NOT #test.b\n TableScan: test
projection=None"`
```
2. optimizer::constant_folding::tests::optimize_plan_or_expr
```
left: `"Projection: #test.a\n Filter: NOT #test.b OR NOT #test.c AS a\n
TableScan: test projection=None"`,
right: `"Projection: #test.a\n Filter: NOT #test.b OR NOT #test.c\n
TableScan: test projection=None"`
```
3. optimizer::constant_folding::tests::optimize_plan_not_exp
```
left: `"Projection: #test.a\n Filter: #test.b AS a\n TableScan: test
projection=None"`,
right: `"Projection: #test.a\n Filter: #test.b\n TableScan: test
projection=None"`
```
4. optimizer::constant_folding::tests::to_timestamp_expr_folded
```
left: `"Projection: TimestampNanosecond(1599566400000000000)\n TableScan:
test projection=None"`,
right: `"Projection: TimestampNanosecond(1599566400000000000) AS
totimestamp(Utf8(\"2020-09-08T12:00:00+00:00\"))\n TableScan: test
projection=None"`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
