joosthooz commented on a change in pull request #11810:
URL: https://github.com/apache/arrow/pull/11810#discussion_r763067097
##########
File path: cpp/src/arrow/util/compression_lz4.cc
##########
@@ -313,6 +335,13 @@ class Lz4FrameCodec : public Codec {
class Lz4Codec : public Codec {
public:
+ Lz4Codec() : compression_level_(kUseDefaultCompressionLevel) {}
Review comment:
It is not used directly anymore, but through child class
`Lz4HadoopCodec`. If it does not exists, the compiler says
```
error: use of deleted function
‘arrow::util::internal::{anonymous}::Lz4HadoopCodec::Lz4HadoopCodec()’
...
Lz4HadoopCodec::Lz4HadoopCodec()’ is implicitly deleted because the default
definition would be ill-formed
...
error: no matching function for call to
‘arrow::util::internal::{anonymous}::Lz4Codec::Lz4Codec()’
```
Another option is to create this constructor for `Lz4HadoopCodec`;
```
Lz4HadoopCodec() {}
```
What do you think?
I'm not able to find `kDefaultCompressionLevel`, also not in the code for
other compressors. Where should this coercion occur?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
