coryan commented on a change in pull request #11916:
URL: https://github.com/apache/arrow/pull/11916#discussion_r768087336
##########
File path: ci/docker/conda-cpp.dockerfile
##########
@@ -54,6 +56,7 @@ ENV ARROW_BUILD_TESTS=ON \
ARROW_WITH_SNAPPY=ON \
ARROW_WITH_ZLIB=ON \
ARROW_WITH_ZSTD=ON \
+ CMAKE_CXX_STANDARD=17 \
Review comment:
> Note this will break OSX for now, so it should only be set for Linux
(as it is done here).
So this change is doing the "Right Thing"[tm] but maybe accidentally?
> See the tracking issue
[conda-forge/clang-compiler-activation-feedstock#17](https://github.com/conda-forge/clang-compiler-activation-feedstock/issues/17)
for that.
Ack.
> Can we remove the explicit setting of `CMAKE_CXX_STANDARD` in CMake
instead?
That is way above my pay grade (for this project). It depends on whether
arrow supports any compiler where the default C++ version is < C++11. For
example, GCC defaults to C++98 until GCC 6.x, and there is a similar story with
Clang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
