xhochy commented on a change in pull request #11916:
URL: https://github.com/apache/arrow/pull/11916#discussion_r768351987
##########
File path: ci/docker/conda-cpp.dockerfile
##########
@@ -54,6 +56,7 @@ ENV ARROW_BUILD_TESTS=ON \
ARROW_WITH_SNAPPY=ON \
ARROW_WITH_ZLIB=ON \
ARROW_WITH_ZSTD=ON \
+ CMAKE_CXX_STANDARD=17 \
Review comment:
My message was mainly a heads-up that on OSX, you need to set
`CMAKE_CXX_STANDARD` to `14`. This is Linux here, so everything is fine here.
I'm not sure about the general removal of `CMAKE_CXX_STANDARD` as
google-cloud-cpp does also set it:
https://github.com/googleapis/google-cloud-cpp/blob/13ec1e946ae1baad6bcae952daf5910649dcfd0a/CMakeLists.txt#L31-L41
Possibly that combination could also be used here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
