pitrou commented on a change in pull request #11916:
URL: https://github.com/apache/arrow/pull/11916#discussion_r768626457
##########
File path: ci/docker/conda-cpp.dockerfile
##########
@@ -54,6 +56,7 @@ ENV ARROW_BUILD_TESTS=ON \
ARROW_WITH_SNAPPY=ON \
ARROW_WITH_ZLIB=ON \
ARROW_WITH_ZSTD=ON \
+ CMAKE_CXX_STANDARD=17 \
Review comment:
Well, we already have the
[following](https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L122-L124):
```cmake
if(NOT DEFINED CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 11)
endif()
```
The only difference AFAICT is that we don't error out if the user explicitly
asked for something earlier than C++11, but that must be a _really_ rare case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
