jhorstmann opened a new pull request #1048:
URL: https://github.com/apache/arrow-rs/pull/1048


   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #980.
   
   # Rationale for this change
   
   We plan to use this new `assume_sorted_dictionaries` flag in our 
implementation of window functions where the data does not really need to be 
sorted by the PARTITION BY expressions. 
   
   # What changes are included in this PR?
   
   I still plan to add a microbenchmark showing the performance improvement.
   
   I'm also looking for a better name of the flag as 
`assume_sorted_dictionaries` doesn't describe the functionality exactly.
   
   # Are there any user-facing changes?
   
   There should be no API changes in this PR, passing `SortOptions` around 
happens mostly internally. The `build_compare` function was kept and it 
delegates to a new function `build_compare_with_options`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to