jhorstmann commented on pull request #1048:
URL: https://github.com/apache/arrow-rs/pull/1048#issuecomment-996163747


   Benchmark results, not as big an improvement as I'd hoped, about 40% faster. 
I guess the `DynComparator` and `is_valid` checks already have some overhead. 
Also a bit unexpected that the high cardinalities are faster.
   
   ```
   lexicographical_partition_ranges(dictionary_values low cardinality) 4096     
                                                                        
                           time:   [1.1289 us 1.1320 us 1.1377 us]
   
   lexicographical_partition_ranges(dictionary_values high cardinality) 4096    
                                                                         
                           time:   [809.36 ns 810.00 ns 810.59 ns]
   
   lexicographical_partition_ranges(dictionary_keys low cardinality) 4096       
                                                                      
                           time:   [686.69 ns 687.22 ns 687.74 ns]
   
   lexicographical_partition_ranges(dictionary_keys high cardinality) 4096      
                                                                      
                           time:   [487.44 ns 487.90 ns 488.57 ns]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to