alamb commented on pull request #1048:
URL: https://github.com/apache/arrow-rs/pull/1048#issuecomment-998844448


   > The other usecase is for partitioning, as used for example for window 
functions. In an expression like SUM(a) OVER (PARTITION BY b ORDER BY c) 
Datafusion will sort by b, c, with this change we could track that b is only 
used for partitioning in the logical plan and then set the new flag in 
SortOptions, regardless of whether the dictionary is actually sorted.
   
   👍  Makes sense
   
   Make sense. Maybe the sort options flag could be named something like 
"sort_dictionary_by_key_value" to make it clear that the request is to sort the 
data such that the same values that are contiguous but not necessarily sorted 
by value. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to