ArianaVillegas commented on a change in pull request #12031:
URL: https://github.com/apache/arrow/pull/12031#discussion_r774813812
##########
File path: cpp/src/arrow/compute/exec/plan_test.cc
##########
@@ -374,13 +374,13 @@
custom_sink_label:OrderBySinkNode{inputs=[collected=:FilterNode], by={sort_keys=
})
.AddToPlan(plan.get()));
EXPECT_EQ(plan->ToString(), R"a(ExecPlan with 5 nodes:
-lhs:SourceNode{outputs=[:UnionNode]}
-rhs:SourceNode{outputs=[:UnionNode]}
-:UnionNode{inputs=[input_0_label=lhs:SourceNode,
input_1_label=rhs:SourceNode], outputs=[:ScalarAggregateNode]}
-:ScalarAggregateNode{inputs=[target=:UnionNode], outputs=[:SinkNode],
aggregates=[
+:SinkNode{inputs=[collected=:ScalarAggregateNode]}
+ :ScalarAggregateNode{inputs=[target=:UnionNode], outputs=[:SinkNode],
aggregates=[
count(i32, {mode=NON_NULL}),
]}
-:SinkNode{inputs=[collected=:ScalarAggregateNode]}
+ :UnionNode{inputs=[input_0_label=lhs:SourceNode,
input_1_label=rhs:SourceNode], outputs=[:ScalarAggregateNode]}
Review comment:
I think we don't need it anymore because indentation gives us an idea
about which nodes are inputs and ouputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
