pitrou commented on a change in pull request #12031:
URL: https://github.com/apache/arrow/pull/12031#discussion_r776816593
##########
File path: cpp/src/arrow/compute/exec/plan_test.cc
##########
@@ -301,11 +301,11 @@ TEST(ExecPlan, ToString) {
{"sink", SinkNodeOptions{&sink_gen}},
})
.AddToPlan(plan.get()));
- EXPECT_EQ(plan->sources()[0]->ToString(),
R"(:SourceNode{outputs=[:SinkNode]})");
- EXPECT_EQ(plan->sinks()[0]->ToString(),
R"(:SinkNode{inputs=[collected=:SourceNode]})");
+ EXPECT_EQ(plan->sources()[0]->ToString(), R"(:SourceNode{})");
+ EXPECT_EQ(plan->sinks()[0]->ToString(), R"(:SinkNode{})");
EXPECT_EQ(plan->ToString(), R"(ExecPlan with 2 nodes:
-:SourceNode{outputs=[:SinkNode]}
-:SinkNode{inputs=[collected=:SourceNode]}
+:SinkNode{}
+ :SourceNode{}
Review comment:
I'm curious, why are there colons at the start of the nodes?
##########
File path: cpp/src/arrow/compute/exec/exec_plan.cc
##########
@@ -157,11 +157,50 @@ struct ExecPlanImpl : public ExecPlan {
return std::move(Impl{nodes_}.sorted);
}
+ std::pair<NodeVector, std::vector<int>> OrderedNodes() const {
Review comment:
What does this do, is this different from the topological sort above? In
any case, please add a comment describing this (what does it return?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
