ArianaVillegas commented on a change in pull request #12031:
URL: https://github.com/apache/arrow/pull/12031#discussion_r776899565
##########
File path: cpp/src/arrow/compute/exec/plan_test.cc
##########
@@ -301,11 +301,11 @@ TEST(ExecPlan, ToString) {
{"sink", SinkNodeOptions{&sink_gen}},
})
.AddToPlan(plan.get()));
- EXPECT_EQ(plan->sources()[0]->ToString(),
R"(:SourceNode{outputs=[:SinkNode]})");
- EXPECT_EQ(plan->sinks()[0]->ToString(),
R"(:SinkNode{inputs=[collected=:SourceNode]})");
+ EXPECT_EQ(plan->sources()[0]->ToString(), R"(:SourceNode{})");
+ EXPECT_EQ(plan->sinks()[0]->ToString(), R"(:SinkNode{})");
EXPECT_EQ(plan->ToString(), R"(ExecPlan with 2 nodes:
-:SourceNode{outputs=[:SinkNode]}
-:SinkNode{inputs=[collected=:SourceNode]}
+:SinkNode{}
+ :SourceNode{}
Review comment:
The format is label: kind_node, so when a node has no label, only:
kind_node remains. We could prevent the colons from appearing when there is no
label.
##########
File path: cpp/src/arrow/compute/exec/plan_test.cc
##########
@@ -301,11 +301,11 @@ TEST(ExecPlan, ToString) {
{"sink", SinkNodeOptions{&sink_gen}},
})
.AddToPlan(plan.get()));
- EXPECT_EQ(plan->sources()[0]->ToString(),
R"(:SourceNode{outputs=[:SinkNode]})");
- EXPECT_EQ(plan->sinks()[0]->ToString(),
R"(:SinkNode{inputs=[collected=:SourceNode]})");
+ EXPECT_EQ(plan->sources()[0]->ToString(), R"(:SourceNode{})");
+ EXPECT_EQ(plan->sinks()[0]->ToString(), R"(:SinkNode{})");
EXPECT_EQ(plan->ToString(), R"(ExecPlan with 2 nodes:
-:SourceNode{outputs=[:SinkNode]}
-:SinkNode{inputs=[collected=:SourceNode]}
+:SinkNode{}
+ :SourceNode{}
Review comment:
The format is label: kind_node, so when a node has no label, only:
kind_node remains. We could prevent the colons from appearing when there is no
label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
