tustvold commented on a change in pull request #1180:
URL: https://github.com/apache/arrow-rs/pull/1180#discussion_r786854907
##########
File path: parquet/src/arrow/record_reader/buffer.rs
##########
@@ -224,22 +229,14 @@ pub trait ValuesBuffer: BufferQueue {
/// - `read_offset` - the offset in [`ValuesBuffer`] to start null padding
from
/// - `values_read` - the number of values read
/// - `levels_read` - the number of levels read
- /// - `rev_valid_position_iter` - a reverse iterator of the valid level
positions
- ///
- /// It is required that:
- ///
- /// - `rev_valid_position_iter` has at least `values_len` elements
- /// - `rev_valid_position_iter` returns strictly monotonically decreasing
values
- /// - `rev_valid_position_iter` returns values in the range
`read_offset..read_offset+levels_len`
- ///
- /// Implementations may panic or otherwise misbehave if this is not the
case
+ /// - `valid_mask` - a packed mask of valid levels
///
fn pad_nulls(
&mut self,
read_offset: usize,
values_read: usize,
levels_read: usize,
- rev_valid_position_iter: impl Iterator<Item = usize>,
+ valid_mask: &[u8],
Review comment:
This change makes tests easier to write, I think is clearer and may in
fact optimize better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
