tustvold commented on a change in pull request #1180:
URL: https://github.com/apache/arrow-rs/pull/1180#discussion_r786856138
##########
File path: parquet/src/arrow/array_reader/byte_array.rs
##########
@@ -668,15 +668,9 @@ mod tests {
assert_eq!(decoder.read(&mut output, 4..8).unwrap(), 0);
let valid = vec![false, false, true, true, false, true, true,
false, false];
- let rev_position_iter = valid
Review comment:
This is an example of how changing pad_nulls to take a packed bitmask
makes the tests less verbose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
