tustvold commented on a change in pull request #1180:
URL: https://github.com/apache/arrow-rs/pull/1180#discussion_r787041129
##########
File path: parquet/src/arrow/array_reader/byte_array.rs
##########
@@ -579,69 +579,18 @@ impl ByteArrayDecoderDictionary {
#[cfg(test)]
mod tests {
use super::*;
+ use crate::arrow::array_reader::test_util::{
+ byte_array_all_encodings, utf8_column,
+ };
use crate::arrow::record_reader::buffer::ValuesBuffer;
- use crate::basic::Type as PhysicalType;
- use crate::data_type::{ByteArray, ByteArrayType};
- use crate::encodings::encoding::{get_encoder, DictEncoder, Encoder};
- use crate::schema::types::{ColumnDescriptor, ColumnPath, Type};
- use crate::util::memory::MemTracker;
use arrow::array::{Array, StringArray};
- use std::sync::Arc;
-
- fn column() -> ColumnDescPtr {
Review comment:
This code is extracted out into test_utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
