[GitHub] [arrow] dragosmg commented on a change in pull request #12179: ARROW-14609 [R] left_join by argument error message mismatch

[GitBox]

dragosmg commented on a change in pull request #12179:
URL: https://github.com/apache/arrow/pull/12179#discussion_r787567978



##########
File path: r/tests/testthat/test-dplyr-join.R
##########
@@ -90,9 +90,57 @@ test_that("Error handling", {
     left_tab %>%
       left_join(to_join, by = "not_a_col") %>%
       collect(),
-    "all(names(by) %in% names(x)) is not TRUE",
-    fixed = TRUE
+    "Join column must be present in data"
   )
+  expect_snapshot({
+    (expect_error(

Review comment:
       the extra brackets print the output. Without brackets it would look like 
the example below and we would lose the main reason for using 
`expect_snapshot()`
   <img width="819" alt="image" 
src="https://user-images.githubusercontent.com/13176361/150107840-d004a6dd-bd8d-4c41-bc86-ea559ed269b4.png";>
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org