dragosmg commented on a change in pull request #12179:
URL: https://github.com/apache/arrow/pull/12179#discussion_r788617132
##########
File path: r/tests/testthat/test-dplyr-join.R
##########
@@ -90,8 +90,56 @@ test_that("Error handling", {
left_tab %>%
left_join(to_join, by = "not_a_col") %>%
collect(),
- "all(names(by) %in% names(x)) is not TRUE",
- fixed = TRUE
+ "Join columns must be present in data"
+ )
+
+ # we print both message_x and message_y with an unnamed `by` vector
Review comment:
I think a [relevant
Jira](https://issues.apache.org/jira/browse/ARROW-14458) already exists. We
might not need another one, but rather update it to reflect current thinking
(i.e. use `expect_snapshot(error = TRUE)` where possible, the future addition
of classed errors to cpp11, etc). What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
