dragosmg commented on a change in pull request #12179:
URL: https://github.com/apache/arrow/pull/12179#discussion_r787675965
##########
File path: r/tests/testthat/test-dplyr-join.R
##########
@@ -90,9 +90,57 @@ test_that("Error handling", {
left_tab %>%
left_join(to_join, by = "not_a_col") %>%
collect(),
- "all(names(by) %in% names(x)) is not TRUE",
- fixed = TRUE
+ "Join column must be present in data"
)
+ expect_snapshot({
+ (expect_error(
Review comment:
We could use `expect_snapshot(error = TRUE)` instead of
`expect_snapshot()` + `(expect_error())`, but we lose the `Output` heading -
something we could live with. See my
[6602362](https://github.com/apache/arrow/pull/12179/commits/660236248de9d4d6abaa2f516053eae44260892c)
commit for the snapshot diff. I think this latest version might be the best
balance between readability & conciseness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
