emkornfield commented on a change in pull request #12158:
URL: https://github.com/apache/arrow/pull/12158#discussion_r800127741
##########
File path: go/arrow/array/array_test.go
##########
@@ -95,13 +96,15 @@ func TestMakeFromData(t *testing.T) {
}, 0 /* nulls */, 0 /* offset */)},
},
+ {name: "dictionary", d: &testDataType{arrow.DICTIONARY},
expPanic: true, expError: "arrow/array: no dictionary set in Data for
Dictionary array"},
+ {name: "dictionary", d: &arrow.DictionaryType{IndexType:
arrow.PrimitiveTypes.Int8, ValueType: &testDataType{arrow.INT64}}, dict:
array.NewData(&testDataType{arrow.INT64}, 0 /* length */,
make([]*memory.Buffer, 2 /*null bitmap, values*/), nil /* childData */, 0 /*
nulls */, 0 /* offset */)},
Review comment:
does it pay to test more index and value types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
