emkornfield commented on a change in pull request #12158:
URL: https://github.com/apache/arrow/pull/12158#discussion_r800127882
##########
File path: go/arrow/array/data.go
##########
@@ -63,6 +64,16 @@ func NewData(dtype arrow.DataType, length int, buffers
[]*memory.Buffer, childDa
}
}
+// NewDataWithDictionary creates a new data object, but also sets the provided
dictionary into the data if it's not nil
+func NewDataWithDictionary(dtype arrow.DataType, length int, buffers
[]*memory.Buffer, childData []arrow.ArrayData, nulls, offset int, dict *Data)
*Data {
+ data := NewData(dtype, length, buffers, childData, nulls, offset)
Review comment:
should we check that childData is empty here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
