emkornfield commented on a change in pull request #12158:
URL: https://github.com/apache/arrow/pull/12158#discussion_r800127832
##########
File path: go/arrow/array/data.go
##########
@@ -29,13 +29,14 @@ import (
// Data represents the memory and metadata of an Arrow array.
type Data struct {
- refCount int64
- dtype arrow.DataType
- nulls int
- offset int
- length int
- buffers []*memory.Buffer // TODO(sgc): should this be an interface?
- childData []arrow.ArrayData // TODO(sgc): managed by ListArray,
StructArray and UnionArray types
+ refCount int64
+ dtype arrow.DataType
+ nulls int
+ offset int
+ length int
+ buffers []*memory.Buffer // TODO(sgc): should this be an interface?
+ childData []arrow.ArrayData // TODO(sgc): managed by ListArray,
StructArray and UnionArray types
+ dictionary *Data // only populated for dictionary arrays
Review comment:
maybe expand the comment to elaborate that for dictionary arrays
buffers will contain nullability and indexes that reference elements in this
variable? (and childdata would be empty)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
