lukecwik commented on a change in pull request #11235: [WIP] Pull bundle
descriptors.
URL: https://github.com/apache/beam/pull/11235#discussion_r398689421
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -81,6 +81,13 @@ service BeamFnControl {
returns (
// A stream of instructions requested of the SDK to be performed.
stream InstructionRequest) {}
+
+ rpc GetProcessBundleDescriptor(GetProcessBundleDescriptorRequest) returns (
Review comment:
I would have expected this to be a separate stream containing SDK requests
similar to how Control works or made Control bidirectional for requests and
responses by making a singular `Instruction` field that is streamed both ways
that contains both Request and Response fields.
The advantage of using a stream is that it may be important to provide
ordering over SDK requests/responses. Putting it into the Control stream allows
for a total ordering between all Runner and SDK requests/responses (to solve
the instruction id collision issue, we can assign servers the "s" prefix and
clients the "c" prefix).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
