lukecwik commented on a change in pull request #11235: [BEAM-9618] Pull bundle
descriptors.
URL: https://github.com/apache/beam/pull/11235#discussion_r401954623
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -112,7 +113,11 @@ def __init__(self,
self._state_handler_factory = GrpcStateHandlerFactory(
self._state_cache, credentials)
self._profiler_factory = profiler_factory
- self._fns = {} # type: Dict[str, beam_fn_api_pb2.ProcessBundleDescriptor]
+ self._fns = KeyedDefaultDict(
+ lambda id: self._control_stub.GetProcessBundleDescriptor(
+ beam_fn_api_pb2.GetProcessBundleDescriptorRequest(
Review comment:
What appears in the default dict if GetProcessBundleDescriptor raises an
error because the call fails?
Does it get propagated to the caller and it fails processing the bundle (is
anything left in the map)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
