lukecwik commented on a change in pull request #11235: [BEAM-9618] Pull bundle
descriptors.
URL: https://github.com/apache/beam/pull/11235#discussion_r401943249
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClientPoolService.java
##########
@@ -105,12 +105,38 @@ public static FnApiControlClientPoolService
offeringClientsToPool(
return newClient.asResponseObserver();
}
+ @Override
+ public void getProcessBundleDescriptor(
+ BeamFnApi.GetProcessBundleDescriptorRequest request,
+ StreamObserver<BeamFnApi.ProcessBundleDescriptor> responseObserver) {
+ final String workerId = headerAccessor.getSdkWorkerId();
+ if (Strings.isNullOrEmpty(workerId)) {
+ // TODO(BEAM-4149): Enforce proper worker id.
+ LOG.warn("No worker_id header provided in getProcessBundleDescriptor
request");
Review comment:
Since this is a new method, we should force all users to supply it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
