robertwb commented on a change in pull request #11222: [BEAM-4150] Don't window
PCollection coders.
URL: https://github.com/apache/beam/pull/11222#discussion_r398789812
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -426,7 +423,8 @@ def _collect_written_timers_and_add_to_deferred_inputs(
pipeline_components, # type: beam_runner_api_pb2.Components
stage, # type: translations.Stage
bundle_context_manager, # type: execution.BundleContextManager
- deferred_inputs # type: MutableMapping[str, PartitionableBuffer]
+ deferred_inputs, # type: MutableMapping[str, PartitionableBuffer]
+ data_channel_coders,
Review comment:
Thanks for calling me out on this. The types themselves aren't very
informative as to their meaning, but I added it here and elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
