robertwb commented on a change in pull request #11222: [BEAM-4150] Don't window
PCollection coders.
URL: https://github.com/apache/beam/pull/11222#discussion_r398790807
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -347,6 +348,22 @@ def add_or_get_coder_id(self,
self.components.coders[new_coder_id].CopyFrom(coder_proto)
return new_coder_id
+ def add_data_channel_coder(self, pcoll_id):
+ pcoll = self.components.pcollections[pcoll_id]
+ proto = beam_runner_api_pb2.Coder(
+ spec=beam_runner_api_pb2.FunctionSpec(
+ urn=common_urns.coders.WINDOWED_VALUE.urn),
+ component_coder_ids=[
+ pcoll.coder_id,
+ self.components.windowing_strategies[
+ pcoll.windowing_strategy_id].window_coder_id
+ ])
+ channel_coder = self.add_or_get_coder_id(
+ proto, pcoll.coder_id + '_windowed')
+ if pcoll.coder_id in self.safe_coders:
+ channel_coder = self.length_prefixed_coder(channel_coder)
Review comment:
Here I want to populate the safe_coders mapping for channel_coder iff the
value coder has such a mapping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
