robertwb commented on issue #11222: [BEAM-4150] Don't window PCollection coders. URL: https://github.com/apache/beam/pull/11222#issuecomment-604619996 As forusing the input/output PCollection names, rather than the GRPC ids, that's a good question. Things are structured this way is mostly to follow the existing code, where things are indexed by these PCollections. In particular, ... -> pcIn -> GBK -> pcOut -> ... gets replaced by ... -> pcIn -> GrpcOut GrpcIn -> pcOut -> ... but the original GBK transform itself is kept around (with its references to pcIn and pcOut--it's the object that "connects" the two) to construct the appropriate grouping buffer. This could be refactored, and may be if GBK becomes a full-fledged operator to make it more streamy, but that seemed out of scope for this change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
