ajamato commented on a change in pull request #11184: [BEAM-4374] Update protos
related to MonitoringInfo.
URL: https://github.com/apache/beam/pull/11184#discussion_r398802911
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/FnApiMonitoringInfoToCounterUpdateTransformer.java
##########
@@ -35,50 +35,82 @@
public class FnApiMonitoringInfoToCounterUpdateTransformer
implements MonitoringInfoToCounterUpdateTransformer {
- final Map<String, MonitoringInfoToCounterUpdateTransformer>
counterTransformers = new HashMap<>();
+ final Map<String, Map<String, MonitoringInfoToCounterUpdateTransformer>>
Review comment:
Can you key this by a tuple instead of a 2 layer dictionary? That might
reduce some of the boilerplate below. I believe the Pair class can work here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
