ajamato commented on a change in pull request #11184: [BEAM-4374] Update protos
related to MonitoringInfo.
URL: https://github.com/apache/beam/pull/11184#discussion_r398810999
##########
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/MSecMonitoringInfoToCounterUpdateTransformerTest.java
##########
@@ -54,39 +58,33 @@ public void setUp() throws Exception {
@Test
public void testTransformReturnsNullIfSpecValidationFails() {
- Map<String, String> counterNameMapping = new HashMap<>();
- counterNameMapping.put("beam:counter:supported", "supportedCounter");
-
Map<String, DataflowStepContext> stepContextMapping = new HashMap<>();
MSecMonitoringInfoToCounterUpdateTransformer testObject =
Review comment:
Can you add a TODO to rename this to
ExecutionTimeMonitoringInfoToCounterUpdateTransformer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
