ajamato commented on a change in pull request #11184: [BEAM-4374] Update protos
related to MonitoringInfo.
URL: https://github.com/apache/beam/pull/11184#discussion_r398804945
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/MSecMonitoringInfoToCounterUpdateTransformer.java
##########
@@ -120,14 +110,19 @@ public CounterUpdate transform(MonitoringInfo
monitoringInfo) {
return null;
}
- long value = monitoringInfo.getMetric().getCounterData().getInt64Value();
+ long value;
+ try {
+ value = VARINT_CODER.decode(monitoringInfo.getPayload().newInput());
Review comment:
Ditto here, please use a one liner helper method to extract the value, here
and in all the transformer classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
