robertwb commented on a change in pull request #11229: [BEAM-9608] Increasing
scope of context managers for FnApiRunner
URL: https://github.com/apache/beam/pull/11229#discussion_r399557974
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -369,8 +366,8 @@ def _store_side_inputs_in_state(self,
state_key = beam_fn_api_pb2.StateKey(
iterable_side_input=beam_fn_api_pb2.StateKey.IterableSideInput(
transform_id=transform_id, side_input_id=tag, window=window))
- bundle_context_manager.worker_handler.state.append_raw(
- state_key, elements_data)
+ runner_execution_context.worker_handler_manager.state_servicer\
Review comment:
Perhaps add a state_servicer() method right on runner_execution_context (and
use several places below)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
