pabloem commented on a change in pull request #11229: [BEAM-9608] Increasing
scope of context managers for FnApiRunner
URL: https://github.com/apache/beam/pull/11229#discussion_r399570655
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -415,24 +412,24 @@ def _run_bundle_multiple_times_for_testing(
cache_token_generator=cache_token_generator)
testing_bundle_manager.process_bundle(data_input, data_output)
finally:
- worker_handler.state.restore()
+
runner_execution_context.worker_handler_manager.state_servicer.restore()
def _collect_written_timers_and_add_to_deferred_inputs(
self,
- pipeline_components, # type: beam_runner_api_pb2.Components
- stage, # type: translations.Stage
+ runner_execution_context, # type: execution.FnApiRunnerExecutionContext
bundle_context_manager, # type: execution.BundleContextManager
deferred_inputs, # type: MutableMapping[str, PartitionableBuffer]
- data_channel_coders, # type: Mapping[str, str]
):
# type: (...) -> None
- for transform_id, timer_writes in stage.timer_pcollections:
+ for transform_id, timer_writes in \
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services