youngoli commented on a change in pull request #11257: [BEAM-9642] Create runtime invokers for SDF methods. URL: https://github.com/apache/beam/pull/11257#discussion_r401926802
########## File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go ########## @@ -0,0 +1,302 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package exec + +import ( + "github.com/apache/beam/sdks/go/pkg/beam/core/funcx" + "github.com/apache/beam/sdks/go/pkg/beam/core/sdf" + "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx" + "github.com/apache/beam/sdks/go/pkg/beam/internal/errors" + "reflect" +) + +// This file contains invokers for SDF methods. These invokers are based off +// exec.invoker which is used for regular DoFns. Since exec.invoker is +// specialized for DoFns it cannot be used for SDF methods. Instead, these Review comment: I'd support that if we can refactor the DoFn-specific behavior out of the core invoker code so the SDF and DoFn invokers can both share that code, while adding on their own unique behavior via ret functions and such. (Just to be clear, by core invoker code I mean the switch statements in fn_arity, and the cached arg slice. I.E. both things that I had to replicate and could potentially be shared, but right now have DoFn-specific logic associated with them.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
