lostluck commented on a change in pull request #11257: [BEAM-9642] Create 
runtime invokers for SDF methods.
URL: https://github.com/apache/beam/pull/11257#discussion_r400528303
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go
 ##########
 @@ -23,29 +23,36 @@ import (
        "reflect"
 )
 
-func invokeCreateInitialRestriction(fn *funcx.Fn, elms *FullValue) (rest 
interface{}, err error) {
+func createInitialRestrictionCallFn(fn *funcx.Fn) (callFn func(*FullValue) 
interface{}, err error) {
 
 Review comment:
   I'm surprised that the return func type doesn't have the return value pair 
wrapped in (), but if gofmt likes it' it's fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to