lostluck commented on a change in pull request #11257: [BEAM-9642] Create runtime invokers for SDF methods. URL: https://github.com/apache/beam/pull/11257#discussion_r401773929
########## File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go ########## @@ -0,0 +1,302 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package exec + +import ( + "github.com/apache/beam/sdks/go/pkg/beam/core/funcx" + "github.com/apache/beam/sdks/go/pkg/beam/core/sdf" + "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx" + "github.com/apache/beam/sdks/go/pkg/beam/internal/errors" + "reflect" +) + +// This file contains invokers for SDF methods. These invokers are based off +// exec.invoker which is used for regular DoFns. Since exec.invoker is +// specialized for DoFns it cannot be used for SDF methods. Instead, these Review comment: Well in principle we could embed the normal invoker in each of these, and have customized initCall or Ret functions which could save some work/optimization duplication. I agree that there's some complexity around doing that, so we can punt it for now. Similarly, the fn_arity thing could be adjusted to generate additional things later on. No action required. Just commentary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
