TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send
Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405823916
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java
##########
@@ -914,6 +923,7 @@ public Object createRunnerForPTransform(
PipelineOptions pipelineOptions,
BeamFnDataClient beamFnDataClient,
BeamFnStateClient beamFnStateClient,
+ BeamFnTimerClient beamFnTimerClient,
String pTransformId,
PTransform pTransform,
Supplier<String> processBundleInstructionId,
Review comment:
This test is `testStateCallsFailIfNoStateApiServiceDescriptorSpecified`. Is
there value in a `testTimerCallsFailIfNoTimerApiServiceDescriptorSpecified` to
exercise the new "Timers are unsupported because ..." exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
