lukecwik commented on a change in pull request #11314: [BEAM-9562] Send Timers
over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405870882
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java
##########
@@ -238,9 +238,14 @@ protected BatchDataflowWorker(
sdkFusedStage =
pipeline == null
? RegisterNodeFunction.withoutPipeline(
- idGenerator,
sdkHarnessRegistry.beamFnStateApiServiceDescriptor())
+ idGenerator,
+ sdkHarnessRegistry.beamFnStateApiServiceDescriptor(),
+ sdkHarnessRegistry.beamFnDataApiServiceDescriptor())
Review comment:
They both use the Data API so no. All were saying here is that we will
re-use the same gRPC channel for both timers and data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
