henryken commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r407072546
########## File path: learning/katas/go/Introduction/Setup/lesson-info.yaml ########## @@ -0,0 +1,22 @@ + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +content: + - Setup Review comment: I think we should not require a separate "Setup" task. How about merging this "Setup" task with the "Hello Beam" task and thus we have 3 answer placeholders in the "Hello Beam" task, i.e. pipeline setup, beam.Create, and pipeline run? I understand the rationale for including the pipeline setup and running as part of the kata. My concern last time for not including the pipeline setup was that it introduces slight difficulty and learning curve for a new student to finish the first kata, i.e. having to do multiple things at once. And thus, I skip the pipeline setup since it's already revealed as part of the skeleton code. If you think we should include the pipeline setup as part of the kata, then we should adopt it for the Java and Python version as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
