damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r408584291
########## File path: learning/katas/go/Introduction/Hello Beam/Hello Beam/pkg/task/task.go ########## @@ -0,0 +1,24 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package task + +import ( + "github.com/apache/beam/sdks/go/pkg/beam" +) + +func HelloBeam(s beam.Scope) beam.PCollection { Review comment: May we consider keeping this? When I consolidated everything into the same file, I received the error `flag redefined: runner`. IntelliJ Edu constrains us to having tests in the test folder in order to achieve lesson task validation, so we can't do any task validation with tests in any other folder. Also, while there doesn't seem to be a consensus around go project structure in the community, this repo seems to follows the `./{cmd,pkg}/*` structure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
